Skip to content

chore(ci): add workflow to suggest splitting large PRs #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 25, 2022

Issue number: #1331

Summary

Changes

Please provide a summary of what's being changed

This new workflow makes a comment on PRs as soon as size/XXL label is added by our PR Size bot. It will suggest the author to break it, but also suggest disregard PRs that eventually grow in size after multiple reviews.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner August 25, 2022 16:59
@heitorlessa heitorlessa requested review from mploski and removed request for a team August 25, 2022 16:59
@boring-cyborg boring-cyborg bot added github-actions Pull requests that update Github_actions code internal Maintenance changes labels Aug 25, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 25, 2022
@heitorlessa heitorlessa linked an issue Aug 25, 2022 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the feature New feature or functionality label Aug 25, 2022
@heitorlessa heitorlessa changed the title feat(ci): add actionlint in pre-commit hook chore(ci): add workflow to suggest splitting large PRs Aug 25, 2022
* develop:
  chore(ci): add linter for GitHub Actions as pre-commit hook (aws-powertools#1479)
@leandrodamascena leandrodamascena requested review from leandrodamascena and removed request for mploski August 25, 2022 18:40
@leandrodamascena
Copy link
Contributor

LGTM

@leandrodamascena leandrodamascena merged commit 62a976f into aws-powertools:develop Aug 25, 2022
heitorlessa added a commit that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality github-actions Pull requests that update Github_actions code internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants